Repository navigation
fix(plugin): align command descriptions across harnesses and test alignment - #55
Merged
Facundo Santiago (santiagxf) merged 1 commit intoNov 16, 2026
Conversation
The feedback command's description is written twice, once in commands/feedback.md for the Markdown hosts and once in commands/aigateway/feedback.toml for Gemini, with nothing tying the copies together. So they drifted. The skill moved to returning an anonymized summary, the Markdown followed, and the Gemini adapter went on telling users it packages a local ZIP for GitHub issues -- a flow the current skill explicitly refuses. The stale description was the visible half. The adapter's prompt still drove the whole v1 flow: consent for a session export, a ZIP, GitHub publication. The skill it points at now rejects full transcripts and says sharing decisions belong to the user, so the adapter was instructing Gemini to do what the skill forbids. Rewrite it to mirror the Markdown command. Check the pair from now on: each .toml description must equal the description of the command it mirrors. The other five already matched, and every skill path the adapters reference resolves. Also move the feedback skill's tests out of the skill directory. Whatever sits in skills/ is downloaded by everyone who installs the plugin, and evals.json and test_feedback.py are development files. They move to tests/feedback/, and the check fails if anything like that reappears. Both checks were run against the previous tree and report exactly these three problems. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Paul Yuknewicz (paulyuk)
approved these changes
Nov 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #50. Targets
fix/plugin-yaml-frontmatter, notmain, because it extends the checker that PR adds.The problem
Every command's description is written twice: once in
commands/<name>.mdfor the Markdown hosts, once incommands/aigateway/<name>.tomlfor Gemini. Nothing ties the copies together, so they drift.feedbackhas drifted, and it is user-visible today:commands/aigateway/feedback.tomlcommands/feedback.mdskills/feedback-ai-gateway/SKILL.md(v2.0.0)The skill moved to returning an anonymized summary and the Markdown followed. The Gemini adapter did not. Gemini users are shown a description of a feature that no longer exists.
The stale description was the visible half. The adapter's prompt still drove the entire v1 flow — consent for a session export, produce a ZIP, publish to a GitHub issue. The skill it points at now rejects full transcripts and states that sharing decisions belong to the user. The adapter was instructing Gemini to do what the skill refuses.
What changed
commands/aigateway/feedback.tomlrewritten to mirrorcommands/feedback.md: summary file in, anonymized file out, no ZIP, no sharing.The checker now compares the pair. Each
.tomldescription must equal the description of the command it mirrors. The other five already match, and everyskills/.../SKILL.mdpath referenced by an adapter resolves.Skill directories no longer carry development files.
skills/feedback-ai-gateway/tests/{evals.json,test_feedback.py}ship to everyone who installs the plugin. They move totests/feedback/, and the checker fails if test or eval files reappear underskills/. The test's import path is updated; all 8 tests still pass.Verification
.tomldescription, and a new fixture file planted underskills/.python3 -m unittest discover -s tests/feedback→ 8 tests, OK.tomllib(Python 3.11+) and is skipped below that, the same way the strict YAML parse is skipped without PyYAML. CI has both.Provenance
Both checks are adapted from
tests/test_plugin.pyin #38. That PR asserts the same two properties; this takes the ideas without the rest of the branch, which is on an orphaned base and conflicting. A third idea there, a 1024-character cap on descriptions, is not included — the longest description in the plugin is 365 characters, so the check could not fire.🤖 Generated with Claude Code